Fix card-selection border weight in the card chooser (CS-11329)#5117
Merged
Conversation
In the card chooser, a selected item showed only the thin 1px button border — the intended teal ring never applied because it relied on AdornContext's :deep stroke rule, which the portaled catalog item didn't pick up. Define the ring directly on `.catalog-item.adorn.selected`: a full-weight 4px `--boxel-highlight` ring, darkening to `--boxel-highlight-hover` on hover, so it stays full-weight whether or not the item is hovered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 4, 2026
Contributor
jurgenwerk
approved these changes
Jun 5, 2026
burieberry
approved these changes
Jun 5, 2026
burieberry
left a comment
burieberry
left a comment
Contributor
There was a problem hiding this comment.
Isn't 4px a bit thick? I remember this as 2px but not a huge deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CS-11329. Split out of #5111.
In the card chooser, a selected item showed only the thin 1px button border — the intended teal ring relied on
AdornContext's:deep(.adorn-stroke.selected)rule, which the portaled catalog item didn't pick up (computedbox-shadowon a selected item wasrgba(0,0,0,0) 0 0 0 0).Fix: define the ring directly on
.catalog-item.adorn.selected— a 4px--boxel-highlightring, darkening to--boxel-highlight-hoveron hover — so it stays full-weight whether or not the item is hovered. (Operator-mode overlays already rendered a correct 4px ring, so this is scoped to the chooser/searchitem-button.)Base:
main. First of a 4-PR split of #5111.🤖 Generated with Claude Code